Douglas Schilling Landgraf has uploaded a new change for review. Change subject: vdsm-reg-setup: fix logging call ......................................................................
vdsm-reg-setup: fix logging call _createUpgradeDir() uses log.error() which log is not defined. This patch fix the call and moves the logging setup before the _createUpgradeDir() call. Change-Id: Id3efebe47d729422c6c9d9b23aaafc01d7bf9a2b Signed-off-by: Douglas Schilling Landgraf <[email protected]> --- M vdsm_reg/vdsm-reg-setup.in 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/26914/1 diff --git a/vdsm_reg/vdsm-reg-setup.in b/vdsm_reg/vdsm-reg-setup.in index 07963cc..fd9c6fa 100644 --- a/vdsm_reg/vdsm-reg-setup.in +++ b/vdsm_reg/vdsm-reg-setup.in @@ -222,7 +222,7 @@ os.chmod(upgradeDir, 0o755) except OSError as err: if err.errno != errno.EEXIST: - log.error( + logging.error( "can not create vdsm upgrade dir: %s" % upgradeDir ) @@ -243,13 +243,13 @@ pidfile = config.get('vars','pidfile') sleepTime = float(config.get('vars','reg_req_interval')) sys.path.append(vdsmDir) + #set up logger + logging.config.fileConfig(loggerConf, disable_existing_loggers=False) + log = logging.getLogger('') _createUpgradeDir(os.path.dirname(config.get('vars', 'upgrade_iso_file'))) if daemonize: createDaemon.createDaemon() - #set up logger - logging.config.fileConfig(loggerConf, disable_existing_loggers=False) - log = logging.getLogger('') if daemonize: log = logging.getLogger('vdsRegistrator') if not daemonize: -- To view, visit http://gerrit.ovirt.org/26914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3efebe47d729422c6c9d9b23aaafc01d7bf9a2b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
