Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/27054/6/vdsm/virt/vmpowerdown.py File vdsm/virt/vmpowerdown.py: Line 91: self.vm._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN) Line 92: return self.event.wait(self.timeout) Line 93: Line 94: def forceCallback(self): Line 95: self.vm.doDestroy() > why do we call doDestroy that does not call self.deleteVm()? because we need to let the engine find the VM in status 'down' to properly register the shutdown event. The engine will then issue full destroy on its own. Line 96: return self.event.wait(self.timeout) Line 97: Line 98: Line 99: class VmReboot(VmPowerDown): http://gerrit.ovirt.org/#/c/27054/6/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 6514: # (new in version 4.15.0) Line 6515: # Since: 4.10.0 Line 6516: ## Line 6517: {'command': {'class': 'VM', 'name': 'shutdown'}, Line 6518: 'data': {'vmID': 'UUID', '*delay': 'int', '*message': 'str', '*reboot': 'bool', > isn't this 80 characters instead of 79? Yes it is but I didn't know there was hard requirement for 79 characters max, since there are multiple violations of this throughout the file. Line 6519: '*timeout': 'int', '*force': 'bool'}} Line 6520: Line 6521: ## Line 6522: # @SnapshotVolumeDriveInfo: -- To view, visit http://gerrit.ovirt.org/27054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30180f9906eb45fa485aa7d773a436e62bd3c815 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
