Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Read default bonding options ......................................................................
Patch Set 8: Verified+1 (1 comment) The patch passes all unit tests, including a new one. The patchset as a whole passes functional tests which now always check that after changing of bonding options, no other (pre-existing) options are set. http://gerrit.ovirt.org/#/c/27680/8/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 623: Return non-empty options differing from defaults, excluding not actual or Line 624: not applicable options, e.g. 'ad_num_ports' or 'slaves'. Line 625: """ Line 626: opts = _realBondOpts(bond) Line 627: mode = opts['mode'][-1] if 'mode' in opts else None This function is called even before a bond exists hence the condition is necessary. 'if opts' should be enough though as 'mode' is presumed to always exist. Line 628: defaults = _getDefaultBondingOptions(mode) Line 629: Line 630: return dict(((opt, val) for (opt, val) in opts.iteritems() Line 631: if val and val != defaults.get(opt))) -- To view, visit http://gerrit.ovirt.org/27680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
