Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults ......................................................................
Patch Set 48: (1 comment) http://gerrit.ovirt.org/#/c/24456/48/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1403: Line 1404: self.assertBondExists(BONDING_NAME, nics[:2], Line 1405: bondings[BONDING_NAME].get('options')) Line 1406: self.assertEquals(self.vdsm_net.getBondMode(BONDING_NAME), Line 1407: REQMODE_BROADCAST) # TODO: redundant? getBondMode (in tests/functional/utils.py) is made redundant by the new check in assertBondExists. Line 1408: Line 1409: bondings = {BONDING_NAME: dict(remove=True)} Line 1410: status, msg = self.vdsm_net.setupNetworks({}, bondings, {}) Line 1411: -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 48 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
