Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices ......................................................................
Patch Set 28: Verified+1 Changes: * tried to de-uglify the code, but the benefits where debateable, and that lead to relaxation of the checks in API.py, thus reverted again. * the net effect if an engine which wants to use the new (muiltiple) graphic devices must send anyway an hollow-soon-to-be-overwritten 'display' param. It is ugly, but I can't find a better solution * de-uglified the names into the schema, it was pointless to repeat 'display' multiple times. Moreover, the new information are really about display, so the name should reflect that. Verification: - the new path was verified using functional tests and vdsClient - the old path was verified using real unaware engine 3.5.0 master (~ alpha1) * creation of VMs using both spice and vnc (but without SSL) * migration of VMs back and forth patched VDSM and vanilla 4.14.8.1 verified together with http://gerrit.ovirt.org/#/c/26897 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
