Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: Prevent ifup from failing due to existing dhclient ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28038/2/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 574: cfg = cfg + 'BOOTPROTO=%s\n' % pipes.quote(ipconfig.bootproto) Line 575: if (ipconfig.bootproto == 'dhcp' and Line 576: os.path.exists(os.path.join(netinfo.NET_PATH, name))): Line 577: # Ask dhclient to stop any dhclient running for the device Line 578: utils.execCmd([dhclient.DhcpClient.DHCLIENT.cmd, '-x', to be tucked inside dhclient.stop(iface) or a better named function. Line 579: self.iface]) Line 580: Line 581: if mtu: Line 582: cfg = cfg + 'MTU=%d\n' % mtu -- To view, visit http://gerrit.ovirt.org/28038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc4116e1064a00aa891003c9c8fdaea61dabca2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Martin Pavlik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
