Dan Kenigsberg has posted comments on this change. Change subject: vm: improve the logging when destroying domains ......................................................................
Patch Set 1: (1 comment) Maybe I should review the following patches in order to understand this one... http://gerrit.ovirt.org/#/c/28023/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4316: self._dom.destroyFlags( Line 4317: libvirt.VIR_DOMAIN_DESTROY_GRACEFUL) Line 4318: except libvirt.libvirtError as e: Line 4319: self.log.warning("Failed to destroy VM '%s' " Line 4320: "gracefully", self.conf['vmId']) even as a stepping stone - this patch should add logging of the specific error that took place (exc_info=True is the simplest way to do that). Line 4321: if (e.get_error_code() == Line 4322: libvirt.VIR_ERR_OPERATION_FAILED): Line 4323: self._dom.destroy() Line 4324: except libvirt.libvirtError as e: -- To view, visit http://gerrit.ovirt.org/28023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib314ecd66bb7ccb95da96605d810041f767bc9e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
