Darshan N has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/26343/8/vdsm/gluster/gfapi.py File vdsm/gluster/gfapi.py: Line 24: Line 25: @makePublic Line 26: def volumeStatsInfoGet(volumeName, volumeServer="localhost"): Line 27: vol = gfapi.Volume(volumeServer, volumeName) Line 28: vol_init = vol.mount() > rc would be better than vol_init Done Line 29: Line 30: if vol_init != 0: Line 31: errMsg = "Failed to mount volume" Line 32: raise ge.GlusterVolumeStatsInfoGetFailedException(err=[errMsg]) Line 26: def volumeStatsInfoGet(volumeName, volumeServer="localhost"): Line 27: vol = gfapi.Volume(volumeServer, volumeName) Line 28: vol_init = vol.mount() Line 29: Line 30: if vol_init != 0: > Does non-zero return value has meaning? Done Line 31: errMsg = "Failed to mount volume" Line 32: raise ge.GlusterVolumeStatsInfoGetFailedException(err=[errMsg]) Line 33: Line 34: # f_blocks = Total number of blocks -- To view, visit http://gerrit.ovirt.org/26343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib628b10c3b9743bb9fef5cbf41195e69ff851efd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
