Dan Kenigsberg has posted comments on this change. Change subject: profile: Test profile decorator format ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27786/2/tests/profileTests.py File tests/profileTests.py: Line 142: def test_ystat_format(self): Line 143: requires_yappi() Line 144: self.ystat_format() Line 145: stats = yappi.YFuncStats() Line 146: stats.add(FILENAME) > YFuncStats would raise if the file is in the wrong format. This is similar I assume that yappi does not raise an AssertionError, and as such, the failure of this test is going to be reported as an error of the test framework. Is that so? I think that Yoav is trying to remove such occurrences. Line 147: Line 148: @profile.profile(FILENAME) Line 149: def profiled_function(self): Line 150: self.assertTrue(profile.is_running()) -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
