mooli tayer has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27193/11/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: VDSM_TOOL="@BINDIR@/vdsm-tool" Line 22: UPGRADE_LOGGING_PARAMS="--verbose --append --logfile=@VDSMLOGDIR@/upgrade.log" will this not break since these have not been defined yet? Line 23: prog=vdsm Line 24: Line 25: #### pre-start tasks #### Line 26: task_configure_coredump() { -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
