Dan Kenigsberg has posted comments on this change. Change subject: blockVolume: Fix NameError when validating volume parameters ......................................................................
Patch Set 1: Code-Review+2 Thanks, Nir. How about adding a couple of unit tests to these validation classmethods? -- To view, visit http://gerrit.ovirt.org/28426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0e7333dafd6adfec37ae880f51aa0a98978641b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
