Dan Kenigsberg has posted comments on this change. Change subject: faqemu hook: move memory limitation to config ......................................................................
Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py File vdsm_hooks/faqemu/before_vm_start.py: Line 31: Line 32: memory = config.get('vars', 'fake_kvm_memory', None) Line 33: arch = config.get('vars', 'fake_kvm_architecture') Line 34: Line 35: if memory is None: How can memory be ever "None"? You define its default as '0' (and as such, you change the default behavior of faqemu), Do not misunderstand me: it is fine to change faqemu behavior. But it should be clearly declared in the commit message and accepted by its users (most importantly ovirt QE). Line 36: if arch == 'x86_64': Line 37: memory = '20480' Line 38: if arch == 'ppc64': Line 39: memory = '262144' Line 34: Line 35: if memory is None: Line 36: if arch == 'x86_64': Line 37: memory = '20480' Line 38: if arch == 'ppc64': why is this elif->if change? Line 39: memory = '262144' Line 40: Line 41: if memory != '0': Line 42: for memtag in ("memory", "currentMemory"): -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
