Dan Kenigsberg has submitted this change and it was merged. Change subject: net models: simplify error condition ......................................................................
net models: simplify error condition An attempt to add a bonding device with no nics ends with a different error, depending whether the bond is already define in the kernel or not. This surprising behaviour means that the functional test testFailWithBadParam fails if BONDING_NAME is removed from the kernel. This patch unifies the error code, returning ERR_BAD_PARAMS in both cases. Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Signed-off-by: Dan Kenigsberg <[email protected]> Reviewed-on: http://gerrit.ovirt.org/28497 Reviewed-by: Antoni Segura Puimedon <[email protected]> --- M vdsm/network/models.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
