Francesco Romani has posted comments on this change. Change subject: vdsm: add support for hostdev passthrough ......................................................................
Patch Set 12: (3 comments) minor nits http://gerrit.ovirt.org/#/c/22462/12/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 1154: # @kdumpStatus: The current status of kdump configuration for the host: Line 1155: # enabled (1), disabled(0), unknown(-1) Line 1156: # (new in version 4.15.0) Line 1157: # Line 1158: # Since: 4.10.0 I guess 4.15.0 was better :) Line 1159: # Line 1160: # Notes: Since ovirt-engine cannot parse software versions in 'x.y.z' format, Line 1161: # the current API truncates @software_version to 'x.y'. Line 1162: ## http://gerrit.ovirt.org/#/c/22462/12/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1488: super(HostDevice, self).__init__(*args, **kwargs) Line 1489: Line 1490: self._nodeptr = self._connection.nodeDeviceLookupByName(self.name) Line 1491: Line 1492: # the device needs to be dettached from the host typo: dettached vs detached Line 1493: self.log.debug('Detaching hostdev %s', self.name) Line 1494: self._nodeptr.dettach() Line 1495: Line 1496: def getPciAddr(self): Line 1500: capsxml.toprettyxml(encoding='utf-8')) Line 1501: Line 1502: capsxml = capsxml.getElementsByTagName('capability')[0] Line 1503: domain = capsxml.getElementsByTagName('domain')[0]. \ Line 1504: firstChild.nodeValue maybe domain = capsxml.getElementsByTagName( 'domain')[0].firstChild.nodeValue is slightly less ugly? your call. Line 1505: bus = capsxml.getElementsByTagName('bus')[0].firstChild.nodeValue Line 1506: slot = capsxml.getElementsByTagName('slot')[0].firstChild.nodeValue Line 1507: Line 1508: self.log.debug('PCI device %s at address {domain: %s bus: %s ' -- To view, visit http://gerrit.ovirt.org/22462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
