Dan Kenigsberg has posted comments on this change. Change subject: vdscli: no need to generate using autoconf ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28676/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 27: from . import SecureXMLRPCServer Line 28: Line 29: Line 30: d_useSSL = False Line 31: d_tsPath = '/etc/pki/vdsm' > Maybe add TRUSTSTORE to constants.py.in? It has no functional benefit, as this default is immediately overwritten by the @TRUSTSTORE@ from config.py. I hate the constant.py jankyard. In particular, the autoconf value of @TRUSTSTORE@ should not be available to vdsm modules - all should care only about the value exposed by config.py. Line 32: d_addr = '0' Line 33: d_port = '54321' Line 34: Line 35: -- To view, visit http://gerrit.ovirt.org/28676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13059d101068cf6fa292baae4fb93ccf0b30db45 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
