Dan Kenigsberg has posted comments on this change. Change subject: vm: narrow down try/except block in releaseVm ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28024/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4569: "Failed to destroy VM '%s' gracefully", Line 4570: self.conf['vmId'], exc_info=True) Line 4571: if (e.get_error_code() == Line 4572: libvirt.VIR_ERR_OPERATION_FAILED): Line 4573: self._dom.destroy() This is the only thing that can raise libvirtError. So please narrow the try-block even further. Line 4574: except libvirt.libvirtError as e: Line 4575: self.log.warning("Failed to destroy VM '%s'", Line 4576: self.conf['vmId'], exc_info=True) Line 4577: -- To view, visit http://gerrit.ovirt.org/28024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c2b60d8f490f9559edad429baf3989e98d05cf6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
