Alon Bar-Lev has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade ......................................................................
Patch Set 9: (3 comments) do you see now progress at engine while running? http://gerrit.ovirt.org/#/c/28244/9/vdsm_reg/vdsm-upgrade File vdsm_reg/vdsm-upgrade: Line 15: Line 16: from xml.sax import saxutils Line 17: Line 18: Line 19: def _format_msg(msg_line): it is printing/outputting it is not format and return a string... Line 20: _XML_QUOTES = {"'": '~'} Line 21: Line 22: msg = "<BSTRAP component='ovirt-node-upgrade' " \ Line 23: "status='OK' message=%s/>" % \ Line 22: msg = "<BSTRAP component='ovirt-node-upgrade' " \ Line 23: "status='OK' message=%s/>" % \ Line 24: saxutils.quoteattr(msg_line, _XML_QUOTES) Line 25: Line 26: print(msg) flush? debug line? Line 27: logging.debug(msg) Line 28: Line 29: Line 30: def main(): Line 66: msg += "<BSTRAP component='RHEV_INSTALL' status='OK'/>" Line 67: else: Line 68: msg = "<BSTRAP component='ovirt-node-upgrade' " \ Line 69: "status='FAIL' message='Upgraded Failed'/>\n" Line 70: msg += "<BSTRAP component='RHEV_INSTALL' status='FAIL'/>" no xml like should be here, all in function. Line 71: Line 72: print(msg) Line 73: logging.debug(msg) Line 74: -- To view, visit http://gerrit.ovirt.org/28244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
