Nir Soffer has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28817/1//COMMIT_MSG Commit Message: Line 12: We can not modify API.py to provide this information in common place Line 13: because it is not needed by mom thread which is calling this verb as Line 14: well. Line 15: Line 16: The threading model of request processing has changed so we can not use > What I mean here is how this information is gathered. Now we collect this i Why collecting the data in the acceptor is better then collecting by the connection thread? How do you deal with multiple clients from different machines connected at the same time? Line 17: thread local. Instead we use dictionary which is updated in Line 18: MultiProtocolAcceptor and is read in Bridge.py and xml binding. Line 19: Line 20: -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
