Nir Soffer has posted comments on this change. Change subject: domainMonitor: Stop domain monitors concurrently ......................................................................
Patch Set 5: Changes: - Ensure that a monitor invokes its finish callback even if exceptions are raised - Remove redundant removal of monitors in waitForMonitor - Log warning if monitor does not exits when removed - Fix incorrect error handling when stopping monitoring - previous code could hide KeyError inside DomainMonitor.stop() - Fix incorrect error handling when waiting for monit - previous code could hide KeyError inside DomainMonitor.wait() - Fix ugliness calling waitForMonitor in stopMonitoring, now simply invoke monitor.wait() -- To view, visit http://gerrit.ovirt.org/27573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
