Dan Kenigsberg has posted comments on this change. Change subject: vm: abort and report error if domain destroy fails ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28025/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4573: self._dom.destroy() Line 4574: except libvirt.libvirtError as e: Line 4575: self.log.warning("Failed to destroy VM '%s'", Line 4576: self.conf['vmId'], exc_info=True) Line 4577: return errCode['destroyErr'] also the "else" branch of line 4570 needs it. remove 8 spaces and I'm fine with this patch. Line 4578: Line 4579: if not self.cif.mom: Line 4580: self.cif.ksmMonitor.adjust() Line 4581: self._cleanup() -- To view, visit http://gerrit.ovirt.org/28025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d5819321cd0cb28aa43678dc65ee83c215c2d7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
