Dan Kenigsberg has posted comments on this change. Change subject: Additional oop functionality ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/27641/15//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-06-15 12:39:49 +0300 Line 6: Line 7: Additional oop functionality Line 8: Line 9: Functionality is still not implemented in IOProcess The English here is not too readable Line 10: and includes: Line 11: directTouch Line 12: truncatefile Line 13: padToBlockSize http://gerrit.ovirt.org/#/c/27641/15/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 93: files = self._iop.listdir(path) Line 94: except OSError: Line 95: if not ignoreErrors: Line 96: raise Line 97: else: this seems to relate to the previous patch? Line 98: for f in files: Line 99: fullpath = os.path.join(path, f) Line 100: if _IOProcessOs(self._iop).path.isdir(fullpath): Line 101: try: -- To view, visit http://gerrit.ovirt.org/27641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
