Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability ......................................................................
Patch Set 4: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in File vdsm/logger.conf.in: Line 67 Line 68 Line 69 Line 70 Line 71 * Tidyness is essential for effective reading. That's the whole reason I started this - I find the logs hard to follow. Things with high variability should come after things that are relatively constant-width (e.g. timestamp). * I agree with Dan that message should come last. I now retain more of the old format. I still think the new one is an improvement. -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Marina Kalinin <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
