Francesco Romani has posted comments on this change.

Change subject: LiveMerge: Add liveMerge capability to vdsCaps
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28998/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1155: # @kdumpStatus:         The current status of kdump configuration 
for the host:
Line 1156: #                       enabled (1), disabled(0), unknown(-1)
Line 1157: #                       (new in version 4.15.0)
Line 1158: #
Line 1159: # @liveMerge:           #optional Indicates if live merge is 
supported on this
> Thanks for your review!
I never thought of this semantic! But I definitely see your point, and I'm fine 
with it.
Let'a see what the maintainer (Dan) thinks about this.
Line 1160: #                       host.
Line 1161: #                       (new in version 4.15.0)
Line 1162: #
Line 1163: # Since: 4.15.0


-- 
To view, visit http://gerrit.ovirt.org/28998
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac66c679166b5687ed3940e517fe6827fe10e258
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to