Federico Simoncelli has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py: Line 41: SDM_LEASE_NAME = 'SDM' Line 42: SDM_LEASE_OFFSET = 512 * 2048 Line 43: Line 44: # Host status codes Line 45: HOST_UNKNOWN = sanlock.HOST_UNKNOWN > I'm OK with your suggestion regarding this issue. +1 for the text string. Line 46: HOST_FREE = sanlock.HOST_FREE Line 47: HOST_LIVE = sanlock.HOST_LIVE Line 48: HOST_FAIL = sanlock.HOST_FAIL Line 49: HOST_DEAD = sanlock.HOST_DEAD http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 129: for domain in domains: Line 130: try: Line 131: status[domain.sdUUID] = domain.getHostStatus(hostId) Line 132: except clusterlock.HostStatusNotAvailable: Line 133: pass Remind me, what is the meaning of a missing sd? If there's any ambiguity please consider something like: try: status[domain.sdUUID] = domain.getHostStatus(hostId) except clusterlock.HostStatusNotAvailable: status[domain.sdUUID] = GET_HOST_NOT_AVAILABLE # or whatever else Line 134: return status Line 135: Line 136: def close(self): Line 137: self.log.info("Stopping domain monitors") -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
