Nir Soffer has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc ......................................................................
Patch Set 6: (1 comment) Looks like the right direction, can be nicer using the bridge. http://gerrit.ovirt.org/#/c/28817/6/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 490: res = True if res is None else res Line 491: if mangledMethod == 'Host_getCapabilities': Line 492: res['lastClient'] = ctx.client.addr[0] Line 493: res['lastClientIface'] = getDeviceByIP( Line 494: ctx.client.socket.getsockname()[0]) I think the right thing is to register a callable in the bridge that takes the results of Host_getCapabilities and add the needed into in it. Line 495: ctx.requestDone(JsonRpcResponse(res, None, req.id)) Line 496: Line 497: @traceback(on=log.name) Line 498: def serve_requests(self): -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
