Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: do not access devices directly outside Vm ......................................................................
virt: do not access devices directly outside Vm VmStatsThread used to access directly the _devices and conf fields of vm.Vm. This patch does a little cleanup by introducing helper getters to mediate the access to the devices for the Vm clients, VmStatsThread being the first. this patch add little benefit on its own but paves the road to extract VmStatsThread from vm.py and put it in sampling.py. Change-Id: I4313da06153fd9f2db90315d16b242352a127d01 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/28478 Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 20 insertions(+), 10 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4313da06153fd9f2db90315d16b242352a127d01 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
