Nir Soffer has posted comments on this change. Change subject: Improve the _validateIoTuneParams so the params are passed as argument ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28713/6//COMMIT_MSG Commit Message: Line 4: Commit: Martin Sivak <msi...@redhat.com> Line 5: CommitDate: 2014-06-24 10:36:26 +0200 Line 6: Line 7: Improve the _validateIoTuneParams so the params are passed as argument Line 8: > Well for one I can actually call it from somewhere else with arguments that Having this as pure function without side effect would be nice. Please improve the commit message so the motivation for this change is clear. Someone reading this commit message in 6 month should understand why this change was made. If the function should be static, why not move it to module function? Since vm is already too big, why not have this validators in another place? Line 9: Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b -- To view, visit http://gerrit.ovirt.org/28713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
