Dan Kenigsberg has submitted this change and it was merged. Change subject: Improve the _validateIoTuneParams so the params are passed as argument ......................................................................
Improve the _validateIoTuneParams so the params are passed as argument This removes side effects from the method and makes it possible to use the validator independently on the current Vm settings. Another advantage is that it is now much easier to write a unittest for the method. Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b Signed-off-by: Martin Sivak <msi...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/28713 Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/virt/vm.py 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
