Michal Skrivanek has posted comments on this change.

Change subject: libvirt: Log time spent in libvirt calls
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/29686/1/lib/vdsm/libvirtconnection.py
File lib/vdsm/libvirtconnection.py:

Line 107:     def wrapMethod(f, methodName):
Line 108:         @functools.wraps(f)
Line 109:         def wrapper(*args, **kwargs):
Line 110:             try:
Line 111:                 with utils.stopwatch(methodName):
what's the overhead for the measurement?
Line 112:                     ret = f(*args, **kwargs)
Line 113:                 if isinstance(ret, libvirt.virDomain):
Line 114:                     for name in dir(ret):
Line 115:                         method = getattr(ret, name)


-- 
To view, visit http://gerrit.ovirt.org/29686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98bdf64d5c6af99e529a6084f0478f1e3fbb4f3d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to