Yoav Kleinberger has uploaded a new change for review. Change subject: tests: revived forgotten test ......................................................................
tests: revived forgotten test It appears that the original author meant for the writeLargeData to be a test, but forgot the `test' prefix. Moreover, previously the test asserted data>4096, where data is a string, which in python is always True. I simplified it a bit, and removed the trivial assertion. Change-Id: I1a847e83046ea12596076fabaa42baba6939e1cd Signed-off-by: Yoav Kleinberger <[email protected]> --- M tests/miscTests.py 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/29780/1 diff --git a/tests/miscTests.py b/tests/miscTests.py index 8cf5970..21b86f6 100644 --- a/tests/miscTests.py +++ b/tests/miscTests.py @@ -301,7 +301,7 @@ self.log.info("Written data reading") self.assertEquals(p.stdout.read(len(data)), data) - def writeLargeData(self): + def testWriteLargeData(self): data = """The Doctor: Davros, if you had created a virus in your laboratory, something contagious and infectious that killed on contact, a virus that would @@ -321,8 +321,7 @@ Daleks, I shall have that power! """ # (C) BBC - Doctor Who - data = data * ((4096 / len(data)) * 2) - self.assertTrue(data > 4096) + data = data * 100 p = utils.execCmd([EXT_CAT], sync=False) self.log.info("Writing data to std out") p.stdin.write(data) -- To view, visit http://gerrit.ovirt.org/29780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1a847e83046ea12596076fabaa42baba6939e1cd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
