Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: migration: replace magic number ......................................................................
virt: migration: replace magic number replace a magic constant with the symbolic name to clarify the intent of the code. What the code does is to check the migration job is still active. The symbolic name was found by checking the docs: http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo (beware of misalinged comments). 'jobType' can be one of http://libvirt.org/html/libvirt-libvirt.html#virDomainJobType Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/28356 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/migration.py 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
