Dan Kenigsberg has posted comments on this change. Change subject: Support ioTune values >2^31 in getStats over xml-rpc ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/30215/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2849: # with numbers bigger than int32_t Line 2850: for ioTune in decStats["ioTune"]: Line 2851: ioTune["ioTune"] = dict((k, utils.convertToStr(v)) for k, v Line 2852: in ioTune["ioTune"].iteritems()) Line 2853: stats[var] = decStats[var] > OK, this makes sense. This code area is so old and ugly... Along most of Vdsm, we tend to convert to string earlier. However the right thing is indeed to extract this nonsense to a single place, which should sit on the BindingXMLRPC module. Line 2854: elif type(decStats[var]) is not dict: Line 2855: stats[var] = utils.convertToStr(decStats[var]) Line 2856: elif var in ('network', 'balloonInfo', 'vmJobs', Line 2857: 'vNodeRuntimeInfo'): -- To view, visit http://gerrit.ovirt.org/30215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5005d7fdc5397df2480fa8d0c15b003a52e8626 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
