Timothy Asir has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/17644/18/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 1058: Line 1059: Line 1060: @makePublic Line 1061: def systemExecuteGsecCreate(): Line 1062: command = _getGlusterSystemCmd() + ["execute", "gsec_create"] Can we return here if any valid pem file already exists? Line 1063: rc, out, err = _execGluster(command) Line 1064: if rc: Line 1065: raise ge.GlusterGeoRepPublicKeyFileCreateFailedException(rc, Line 1066: out, err) -- To view, visit http://gerrit.ovirt.org/17644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
