Dan Kenigsberg has submitted this change and it was merged. Change subject: Changing isconfigured parameter semantics ......................................................................
Changing isconfigured parameter semantics Currently isconfigured holds boolean and that way the name is misleading as True doesn't mean the module is actually configured. This patch changes that and put in isconfigured just the ret value of isconfigured() on the specific module instead of calling it twice, and later on we use this parameter to decide when to reconfigure the module or not. Change-Id: Ifb7f6c234993701d912ecf731b4927c380fd7d13 Signed-off-by: Yaniv Bronhaim <[email protected]> Reviewed-on: http://gerrit.ovirt.org/30571 Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: mooli tayer <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurator.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Yaniv Bronhaim: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb7f6c234993701d912ecf731b4927c380fd7d13 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
