Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsm: Add zombiereaper to supervdsm
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/28915/6/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 256:                 raise err
Line 257: 
Line 258:             return res
Line 259:         finally:
Line 260:             zombiereaper.autoReapPID(proc.pid)
why not to register the pid just after you start proc ?
Line 261: 
Line 262:     @logDecorator
Line 263:     def validateAccess(self, user, groups, *args, **kwargs):
Line 264:         return self._runAs(user, groups, _validateAccess, args=args,


-- 
To view, visit http://gerrit.ovirt.org/28915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5333caf7a1162c5d783f556bb9204fb74d1ab469
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to