Dan Kenigsberg has submitted this change and it was merged. Change subject: pyroute2: optional configurator added ......................................................................
pyroute2: optional configurator added Pyroute2 was added as new optional configurator. pyroute2 library, which it requires, is not listed as a dependency because it is not strictly necessary. If you want to use this configurator, you have to install current library version (0.2.12) from pip or GitHub https://github.com/svinota/pyroute2. If someone tries to use it and does not have it installed, it writes an ERROR log and uses Ifcfg instead. Necessary changes were made in spec file, debian install file and Makefile because of the new file network/configurators/pyroute_two.py It makes sense to have iproute2 and pyroute2 options in config file. pyroute_two looks ugly. Anyway we can not rename pyroute_two.py too because of import conflicts with library. Change-Id: I12a1c2b9c20b3d47f4b255d6a3502feee1cfbbdb Signed-off-by: Petr Horáček <[email protected]> Reviewed-on: http://gerrit.ovirt.org/30474 Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M debian/vdsm.install M lib/vdsm/config.py.in M vdsm.spec.in M vdsm/network/api.py M vdsm/network/configurators/Makefile.am 5 files changed, 16 insertions(+), 2 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12a1c2b9c20b3d47f4b255d6a3502feee1cfbbdb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
