Yaniv Bronhaim has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator ......................................................................
Patch Set 5: -Code-Review (1 comment) so still need to improve the comments. not only me complaining http://gerrit.ovirt.org/#/c/30909/5/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 760: Line 761: rc = service.service_reload("multipathd") Line 762: if rc != 0: Line 763: status = service.service_status("multipathd", False) Line 764: if status == 0: > If the service is not running, this will raise ServiceOperationError, not r nice catch .. Line 765: raise RuntimeError("Failed to reload Multipath.") Line 766: Line 767: def isconfigured(self, *args): Line 768: """ -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
