Sergey Gotliv has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet ......................................................................
Patch Set 2: Code-Review+1 (1 comment) In general it requires network team review, patch looks good to me based on the Equalogic docs therefore +1. http://gerrit.ovirt.org/#/c/31529/2//COMMIT_MSG Commit Message: Line 19: Line 20: The proposed changes are reccomended by the storage vendor and are described Line 21: in documents bellow: Line 22: - http://en.community.dell.com/dell-groups/dtcmedia/m/mediagallery/20371245/download.aspx Line 23: - https://support.equallogic.com/WorkArea/DownloadAsset.aspx?id=8727 Consider to change this commit message and summarize your changes instead sending me to read entire equalogic documentation: ARP Flux problem described in chapter 2.1.4 here http://linux-ip.net/html/ether-arp.html and solution is described in the document mentioned by you but this is 5 lines chapter while the whole document contains 25 pages. Other than that this patch looks ok. Line 24: Line 25: Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Line 26: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1112861 -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
