Nir Soffer has posted comments on this change. Change subject: ioprocess: Move and reword rename() warning log line ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32194/1/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 229: if log.isEnabledFor(logging.DEBUG): Line 230: log.warn("*DEPRECATED* Renaming a non-empty directory is not " Line 231: "an atomic operation. It is only supported for backward " Line 232: "compatibility with existing algorithms and will be " Line 233: "removed when possible.") > Till we have a clear API deprecation process, I personally rather this to b logs are not the place for warnings - we have warnings module for this: https://docs.python.org/2.6/library/warnings.html Using warnings, developers of higher level code can control the warnings from lower level parts as needed. If we have an issue with code that does things in the wrong way, please open a bug. Line 234: Line 235: _IOProcessFileUtils(self._iop).cleanupdir(newpath, False) Line 236: self.mkdir(newpath) Line 237: for fname in self.listdir(oldpath): -- To view, visit http://gerrit.ovirt.org/32194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d83f91803515845c993c01c23390aaf1d757dff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
