Nir Soffer has posted comments on this change.

Change subject: hsm: check volume existence in prepareImage
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/31937/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3217:         :type sdUUID: UUID
Line 3218:         :param spUUID: The UUID of the storage pool that owns the 
volume.
Line 3219:         :type spUUID: UUID
Line 3220:         :param imgUUID: The UUID of the image contained on the 
volume.
Line 3221:         :type imgUUID: UUID
For another patch: document the leafUUID parameter
Line 3222:         """
Line 3223:         vars.task.getSharedLock(STORAGE, sdUUID)
Line 3224: 
Line 3225:         imgVolumesInfo = []


-- 
To view, visit http://gerrit.ovirt.org/31937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to