Dan Kenigsberg has posted comments on this change. Change subject: make: Run fast checks before slow ones ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32532/1/Makefile.am File Makefile.am: Line 109: done ; \ Line 110: $(PEP8) --exclude="$${exclude}" --filename '*.py,*.py.in' . Line 111: $(PEP8) $(PEP8_WHITELIST) Line 112: Line 113: # Note: dependencies ordered by time needed to run them > Yes but it is not related to automake. Make will run the dependent target b Sorry, I still do not understand the purpose of the change to check-recursive. Would you elaborate why you changed check-local? (Nit: with -j, make would not maintain order) Line 114: check-recursive: gitignore pyflakes pep8 Line 115: Line 116: all-local: \ Line 117: vdsm.spec -- To view, visit http://gerrit.ovirt.org/32532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
