Nir Soffer has posted comments on this change. Change subject: profiling: Add support for memory profiling ......................................................................
Patch Set 4: (1 comment) I think we should move this into the new profiling package: lib/vdsm/profiling/mem.py http://gerrit.ovirt.org/#/c/32019/4/vdsm/vdsm File vdsm/vdsm: Line 69: signal.signal(signal.SIGUSR1, sigusr1Handler) Line 70: zombiereaper.registerSignalHandler() Line 71: Line 72: profile.start() Line 73: profile_mem.start() Lets replace this with: from vdsm import profiling ... profiling.start() An let the profiling package start all profilers. I don't like to modify vdsm again when we add new profilers. Line 74: Line 75: libvirtconnection.start_event_loop() Line 76: Line 77: if config.getboolean('irs', 'irs_enable'): -- To view, visit http://gerrit.ovirt.org/32019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
