Adam Litke has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32836/1/tests/qemuimgTests.py File tests/qemuimgTests.py: Line 115: info = qemuimg.info('unused') Line 116: self.assertEquals('base.img', info['backingfile']) Line 117: Line 118: Line 119: class FakeExecCmd(object): Would be nice if the existing tests and the new ones used a consistent FakeExecCmd mechanism. Line 120: Line 121: def __init__(self, *calls): Line 122: self.calls = list(calls) Line 123: self.saved = None -- To view, visit http://gerrit.ovirt.org/32836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Kevin Wolf <kwolf%[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
