Adam Litke has posted comments on this change.

Change subject: tests: add simple balloon functional testcase
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/12820/15/tests/functional/vmQoSTests.py
File tests/functional/vmQoSTests.py:

Line 65: 
Line 66:         with RunningVm(self.vdsm, customization) as vm:
Line 67:             self._waitForStartup(vm, VM_MINIMAL_UPTIME)
Line 68:             with self._balloonPolicy(policy):
Line 69:                 time.sleep(12)  # MOM policy engine wake up every 10s
I wouldn't gate this patch, but we really need to expand the VirtTests 
framework so that we can restart mom with a shorter interval.  12s just to wait 
for mom to do nothing is a shame.
Line 70:                 status, msg, stats = self.vdsm.getVmStats(vm)
Line 71:                 self.assertEqual(status, SUCCESS, msg)
Line 72:                 self.assertEqual(stats['balloonInfo']['balloon_cur'], 
0)
Line 73: 


-- 
To view, visit http://gerrit.ovirt.org/12820
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to