Federico Simoncelli has posted comments on this change. Change subject: fileSD: Inline private constant in the single call site ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32724/2/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 646: Line 647: # For pattern='*' in mixed pool (block and file domains) Line 648: # glob will return sd.BLOCKSD_DIR and sd.GLUSTERSD_DIR among Line 649: # real mount points. Remove these directories from glob results. Line 650: ignore_dirs = ('/' + sd.BLOCKSD_DIR, '/' + sd.GLUSTERSD_DIR) Why rebuilding this every time? It's fixed. Line 651: Line 652: mntList = [mnt for mnt in glob.iglob(fileDomPattern) Line 653: if not mnt.endswith(ignore_dirs)] Line 654: -- To view, visit http://gerrit.ovirt.org/32724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8430a05dd454c34217bb051345633aec4351738 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
