Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: sampling: more cautious disk stats check ......................................................................
virt: sampling: more cautious disk stats check In commit d6d0eb763e623 we changed the disk stats collection to deal with the benign case of known-missing disk stats samples, to avoid add bogus error on the logs. Unfortunately a case was missing in the live storage migration flow, which causes TypeError: argument of type 'NoneType' is not iterable in the logs defeating the purposes of the originating change. This patch fixes this issue by adding the missing check. Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/33482 Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/virt/vm.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches