Alon Bar-Lev has posted comments on this change. Change subject: tool: avoid swallowing errors in seboolsetup calls. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in File vdsm.spec.in: Line 820: /etc/sysctl.conf Line 821: Line 822: if /usr/sbin/selinuxenabled; then Line 823: %{_bindir}/vdsm-tool sebool-unconfig Line 824: fi I think you want to clean it up anyway... and ignore whatever error, as it was. Line 825: Line 826: %{_bindir}/vdsm-tool remove-saslpasswd Line 827: Line 828: if /sbin/initctl status libvirtd >/dev/null 2>/dev/null ; then -- To view, visit http://gerrit.ovirt.org/33737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
