Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-infra: zombie-reaper refactor ......................................................................
Patch Set 1: (1 comment) I don't have anything too important to comment on. lets push new version of it, without the tab in the spec and the copywrites where needed and move forward with it .. http://gerrit.ovirt.org/#/c/31301/1/configure.ac File configure.ac: Line 132: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm']) Line 133: AC_SUBST([vdsmrepo], ['/rhev/data-center']) Line 134: AC_SUBST([vdsmpylibdir], ['${pyexecdir}/vdsm']) Line 135: AC_SUBST([vdsminfradir], ['${vdsmpylibdir}/infra']) Line 136: AC_SUBST([zombiereaperdir], ['${vdsminfradir}/zombiereaper']) > It's one line above this one. mm.. oops Line 137: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool']) Line 138: AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests']) Line 139: Line 140: # VDSM registration default paths -- To view, visit http://gerrit.ovirt.org/31301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86a7d8d2f512395c2f50e21430b9e939f553e91b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
