Nir Soffer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
......................................................................
Patch Set 2: Code-Review-1
This does two unrelated changes:
1. Change the indentation of existing docstrings from:
"""
first line
more lines...
"""
To:
"""first line
more lines...
"""
This change is not required for extending documentation. More, it is a bad
change and not required by pep8 - both style of docstrings are valid (otherwise
pep8 tool would fail the build).
This is an issue of style - when you edit other people code, you respect their
style.
2. Extend documentation - looks good on brief read
Please focus on the purpose of this patch and use the style already used
in this module.
If you want to do style changes, suggest them in a separate patch.
--
To view, visit http://gerrit.ovirt.org/34045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f4da9a7a2a7917c354137833d66edf0fbc95510
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Dima Kuznetsov <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
