Nir Soffer has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/28915/13/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 251: proc.terminate() Line 252: Line 253: # Add to zombiereaper if process has not been waited upon Line 254: if proc.exitcode is None: Line 255: zombiereaper.autoReapPID(proc.pid) Here it does make a big difference, but we could simplify by passing the pid to zombiereaper anyway. We don't want this kind of check in other 100's places in the code, because this can save sometimes couple of microseconds. The root cause is the bad implementation of terminate, waiting up to 0.1 seconds - a realy bad idea. What if you are writing a non-blocking server? Line 256: Line 257: if err is not None: Line 258: raise err Line 259: -- To view, visit http://gerrit.ovirt.org/28915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5333caf7a1162c5d783f556bb9204fb74d1ab469 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
